AgeCommit message (Collapse)AuthorFilesLines
2014-11-25Automatic commit of release 19.0beaker-19.0Dan Callaghan7-8/+8
2014-11-25update release notes for 19.0 with some last minute bugsDan Callaghan1-0/+12
2014-11-20combine db migration 1c10e575800c into 3fc28d7eb6d3Dan Callaghan4-49/+57
... to avoid two sets of ALTER TABLE statements on the log_* tables. Bug: 1163540 Change-Id: Ieec8014ab397206c649eef12271ecbdc4b2f2385
2014-11-20Fix for arch specific netboot configurationAmit Saha2-3/+2
In a0635104d537ec539bf2fcf69f24f4f1c3ce3cd0, netboot configuration routine, configure_all() was fixed to be called with the distro tree arch and not the system supported archs. Bug: 1165489 Change-Id: I3d399485288b3e03fc9a1a1d67d37eb5fc761336
2014-11-11Automatic commit of release 19.0rc2beaker-19.0rc2Dan Callaghan7-8/+8
2014-11-11Misc/ match all tags, not just beaker-0*Dan Callaghan1-1/+1
The beaker-0* pattern was needed to avoid matching task tags (such as beaker-distribution-install-1_11-11 etc). Now that we have dropped the leading zero from Beaker versions that pattern is no longer suitable. Since we are not keeping tasks in Beaker's git repo anymore we can just remove the pattern entirely and match all tags. Change-Id: I7579e83b710727e27ad12d988eb536a70f89e2fd
2014-11-11Automatic commit of release 19.0rc1beaker-19.0rc1Dan Callaghan7-9/+9
2014-11-11release notes for 19Dan Callaghan12-103/+203
Change-Id: I93c39b8b394cbf361badae1d963043249e89deb2
2014-11-11tests: fix timing issue in test_group_editDan Callaghan1-0/+6
Occasionally the browser.get() will fetch back the groups list before the deletion has finished. To avoid that, we wait for the flash message indicating deletion before moving on. Traceback (most recent call last): File "/usr/lib/python2.6/site-packages/bkr/inttest/server/selenium/", line 394, in test_remove_self_admin_group check_group_search_results(b, absent=[Group.by_name(u'admin')]) File "/usr/lib/python2.6/site-packages/bkr/inttest/server/", line 125, in check_group_search_results 'not(.//td[1]/a/text()="%s")]' % group.group_name) File "/usr/lib64/python2.6/site-packages/selenium/webdriver/remote/", line 230, in find_element_by_xpath return self.find_element(by=By.XPATH, value=xpath) File "/usr/lib64/python2.6/site-packages/selenium/webdriver/remote/", line 662, in find_element {'using': by, 'value': value})['value'] File "/usr/lib64/python2.6/site-packages/selenium/webdriver/remote/", line 173, in execute self.error_handler.check_response(response) File "/usr/lib64/python2.6/site-packages/selenium/webdriver/remote/", line 166, in check_response raise exception_class(message, screen, stacktrace) NoSuchElementException: Message: Unable to locate element: {"method":"xpath","selector":"//table[@id=\"widget\" and not(.//td[1]/a/text()=\"admin\")]"} Change-Id: I45647031f56ee45bb1bd330c98c9289c36c93f91
2014-11-11avoid issuing lots of SELECTs when deleting lab controllersDan Callaghan9-64/+92
Bug: 802641 Change-Id: I35ca17a496eab7c536286318dfa864cc74e68ba3
2014-11-11only show scary warning on Provision tab if a recipe is runningDan Callaghan2-9/+15
Instead of always showing a big fat "Caution", which just causes extra visual noise, we show a shorter and less obtrusive message only when the system is running a recipe. That is the only case where the behaviour in Beaker 19 will be different than earlier versions (previously it would implicitly schedule a job instead of provisioning) and it's also the only time where provisioning is probably not what the user wants to do. Also updated the confirmation box to match the wording from the power confirmation box, in case the system is reserved by someone else. Change-Id: I5aa4812da0118716f1c4f72a7248593e9927b445
2014-11-10Use the distro tree architecture and not the system archs whenAmit Saha3-2/+19
configuring netboot Change-Id: Id6e43ae430bce63122abdbf82725571e3d070965
2014-11-10Allow creating test systems with multiple supported architecturesAmit Saha2-5/+27
Change-Id: I2403eaf3d1084c74bc705439c3dfde9e24aca509
2014-11-07Merge branch 'release-0.18' into developDan Callaghan19-0/+27
2014-11-07release notes for new system pageDan Callaghan6-0/+164
Change-Id: I1915b9aeb84b7e2da77cd0f1ddc9a42e9bb738e2
2014-11-06fix reservesys notification for OpenStack instancesDan Callaghan5-68/+139
Currently Beaker is sending out a link to /view/<fqdn> which is not correct for OpenStack instances. Converted to use a Jinja template since we now have some logic in there. Also updated the tests to use more known values so that we have less of the original template logic repeated in the tests. Change-Id: Idf5028df410db689f641c33c6c448986af38f0ae
2014-11-06fix population of command grid when submitting a new commandDan Callaghan2-21/+41
Because the System#command_queue attribute is actually a PageableCollection running in server mode, it could be currently storing any page -- possibly with a sort or filter applied. So we can't just always insert the new command at the top and assume that is the right place. The easiest approach is to just refresh the command queue grid from the server after we have finished enqueuing our new command(s). This patch also updates the 'reboot' logic so that it first saves 'off' and then only saves 'on' after that has succeeded, to ensure they are ordered correctly. Bug: 1144193 Change-Id: Ied0e3744ebc30be94e7741bcaedb80169876f45d
2014-11-06some tweaks to the appearance of system page widgetsDan Callaghan9-28/+130
This based on recommendations from the HSS UX team, see the bug for full details. Bug: 1144190 Change-Id: I8d9ee7ecb0c770211ef866938d839e047896a549
2014-11-06bkr system-modify --conditionDan Callaghan3-19/+57
Bug: 804479 Change-Id: Ie80ffb29c9635989be82dfa9ad33fd04fa25ba01
2014-11-06access policy widget: handle policies with no rulesDan Callaghan2-2/+14
We need the AccessPolicy#rules attribute to always be a Collection object, even if it contains no actual rules. Bug: 1160513 Change-Id: I7629510cb3fe1a2f112f132c36ea586dbe00f3e3
2014-11-05refresh the commands grid in the Power tab after submitting a provision on ↵mjia2-0/+32
the system page Bug: 1144195 Change-Id: Icbf0d4dc139f2b12ff60d5d7831c0e3f8974ad80
2014-11-05Remove build dep on python-setuptools-develAmit Saha1-1/+1
2014-11-05Fix modal behavior upon HTTP errorAmit Saha18-59/+60
Bug: 1144203 Change-Id: I1425f0ed7ece2fbb86dcab60a58259af4b331058
2014-11-04prevent bash syntax errors if snippets are emptyrelease-0.18Dan Callaghan18-0/+20
Bug: 1160091 Change-Id: Id81a0e1476e30ccf01fa9c1c4830c65fe95e0834
2014-11-04fix tofu for FontAwesome icons in BackgridsDan Callaghan1-1/+5
This was a mistake in commit 8d5ae86c (upgrade to FontAwesome 4.2.1). The .fa-icon() class is needed so that we have the right font-family and other properties set. I never noticed the problem because I had FontAwesome installed systemwide and so my browser was finding the glyphs there. Change-Id: I02ab234c8c6db6a0ca3bdc3605dd91b8f9f313da
2014-11-03'control_system' permission does not imply permission to provisionDan Callaghan6-11/+76
We need an extra permission checking method to cover provisioning (that is, the 'configure_netboot' command) particularly, rather than just checking that power commands can be executed. This basically matches the historical (pre-19) behaviour where "direct" provisioning was only offered if you had reserved the system. Bug: 1144196 Change-Id: I85c708be56b7d2188ef27527c3f3188ba1bb602b
2014-11-03fix some SAWarningsDan Callaghan4-12/+24
Change-Id: I1777320eb676d2440f1502529a2d24f3393a5b92
2014-11-03set no_clock_sync for guests and OpenStack VMsDan Callaghan3-25/+11
Change-Id: I21665de28f8186f618249844328a09b964f9f6a4
2014-10-30test_group_edit: fix timing issue with is_text_presentDan Callaghan2-3/+11
We've really got to stop using that function. FAIL: bkr.inttest.server.selenium.test_group_edit:TestGroupsWD.test_remove_self_admin_group /usr/bin/vim +394 src/bkr/inttest/server/selenium/ # test_remove_self_admin_group self.assertTrue(not is_text_present(b, 'admin')) AssertionError: False is not True Change-Id: I8b370576c3cfca784080d61911c39eea0bb11fa4
2014-10-30tidy up usages of /tmp in testsDan Callaghan7-29/+41
Removed all hardcoded /tmp paths. There are a few things (like basepath.harness) which we can't put in a dynamically created /tmp directory, so they are moved to ./ when running tests from a git checkout (with a corresponding .gitignore rule). Also ensured that all temp files and directories are cleaned up. The only gotcha is that the cleanup does not always happen if nose is interrupted during a run. The end result is that for a fully passing test run, nothing will be left behind in /tmp. Change-Id: Iff060ea5b45ca028af128fce98ac4e3b4b40782e
2014-10-30consolidate basepath defaults into app.cfgDan Callaghan6-12/+12
This way we will always get the proper default value, even if a config file doesn't specify the paths explicitly (for example in tests). Change-Id: Iaac02de38d680514a9978bd51917a13101753881
2014-10-29tests: call session.close() after every test caseDan Callaghan71-259/+228
This is an attempt at reducing the overall memory consumption of the test process when running the full test suite. Change-Id: I0fc5f3f7116cb1f85a685399fe8b804808be805d
2014-10-29avoid hardcoded /tmp paths in unit testsDan Callaghan4-125/+90
The hardcoded paths are causing concurrent Jenkins builds to interfere with each other. Change-Id: Ic8e87207f967bf06f10b1769bb71b4f5501fb020
2014-10-29fix timing issues with logout/loginDan Callaghan1-6/+5
Newer Firefox+Selenium revealed a timing issue with the logout() function. It does not wait for the page load to finish after logging out, so a test may send another request straight away which could be processed before the logout was actually handled. The particular case I saw this was with logout() immediately followed by login(). Since login() re-loads / it may see a page that is still logged in from before. I also removed the extra step of loading / at the start of login(), to avoid some unnecessary roundtrips, although in some cases we still need to do it because the test is calling login() before it loads any page at all. Change-Id: Ib730387662493eaf0aea22ffe371f083a5b81000
2014-10-29pass -noreset to XvfbDan Callaghan1-1/+1
This option tells Xvfb not to "reset" itself after the last client disconnects (which happens every time Firefox is killed, since it is the only client). While Xvfb is resetting there is apparently a window during which it is not accepting connections. This is the cause of intermittent "cannot open display" errors from Firefox, if it starts up while Xvfb is in the middle of a reset. Many thanks to Peter Hutterer for pointing this out! Change-Id: I6ea1e8a82f90130a2414e17679201422f7b29aee
2014-10-28Allow reserving manual systems via reserve workflowAmit Saha4-11/+52
Bug: 1093226 Change-Id: If9de2d3c0bc4a527ff448fa91dac6b4bba8acfb7
2014-10-27Preserve distro selection when system search is used in Reserve WorkflowAmit Saha2-2/+7
Bug: 1154887
2014-10-27require non-empty power addressDan Callaghan3-5/+12
Every power script requires at least a power address, it doesn't make sense not to have one. The power.power_address column is non-NULLable for that reason. So we should also enforce that it's not the empty string. Bug: 1152887 Change-Id: Ia978ea74502ade2537d2c1175e28cfbeef4900ed
2014-10-27fix db downgrade issues with production snapshotsDan Callaghan4-13/+28
Updated the 0.17 downgrades to deal with the two possible unique constraint names, uc_user_id or user_id. Removed the test for 20140109 entirely because that snapshot was a mixture of 0.14 and 0.15, due to the postponed 0.15 upgrade. It's not worth making our automatic migrations handle that mess. Change-Id: I4706c231d8ae7c9efb4a0817d2efc12ce48f61f8
2014-10-24Release note for 0.18.4Amit Saha1-0/+7
2014-10-24Merge branch 'release-0.18' into developAmit Saha23-21/+1216
Conflicts: IntegrationTests/src/bkr/inttest/server/kickstarts/AtomicHost-defaults.expected IntegrationTests/src/bkr/inttest/server/kickstarts/Fedora18-harness-contained-custom.expected IntegrationTests/src/bkr/inttest/server/kickstarts/Fedora18-harness-contained.expected IntegrationTests/src/bkr/inttest/server/ Server/bkr/server/kickstarts/default Server/bkr/server/snippets/docker_harness
2014-10-16upgrade to Bootbox 4.3.0Dan Callaghan5-12/+14
Bug: 1145864 Change-Id: I848da51273fffa6c512dc0b79c912374c3d62c97
2014-10-14docs: downgrade instructions, with a list of database versionsDan Callaghan1-3/+23
Bug: 682030 Change-Id: I39bb4fcd7dbc7bab0fec800eec0fae51c7576eaf
2014-10-14fix cloning of reserve workflow jobs with a LC requirementDan Callaghan2-2/+30
The bug was just that the XML being stored in recipe.host_requires did not have an enclosing <hostRequires/> element, which is expected by the cloning process. Bug: 1144205 Change-Id: Ieb824970857850e959d599b410e6427c74ece024
2014-10-14reserve workflow: tell the user if their recipe matches no systemsDan Callaghan2-1/+39
Bug: 1062086 Change-Id: I2c1876fb81e4163009b6423bbda8863fa55cac10
2014-10-14beaker-init: need to stamp revision after determining itDan Callaghan2-0/+10
This was a mistake in commit 2df6c707, the patch for determining the schema version for an unstamped database. The version determination worked properly but the version was never actually stamped, so the upgrade would proceed but alembic_version would be left empty. Re-running the upgrade again would see an unstamped database which would then repeat the post-0.18 upgrades, which would then fail. Bug: 682030 Change-Id: Ic3bc8acd7c1772e2d195b7a54a0d404fdb8acb13
2014-10-14--debug option for beaker-initDan Callaghan1-1/+3
Change-Id: I6d7217c8989d11ea42ba78d58b1639941b79adbf
2014-10-14also test migration on real production schemasDan Callaghan6-3/+10787
These tests shook out a lot of bugs in older upgrades, which are fixed/worked around by prior patches in the series leading up to this one. Change-Id: Iae7eeb7aa76ddb13ce9d1d1898a450dcf2a34b64
2014-10-14remove database-side defaultsDan Callaghan1-0/+30
See the bug report for complete discussion/rationale. Some other previous database-side defaults are removed as a side effect of the upgrades in commit 5cf89f53. Bug: 1069438 Change-Id: Ic26ec9bbbb848cb5917a36115fb2a847c73c7121
2014-10-14fix type of task.owner column in old databasesDan Callaghan1-0/+25
This was a mistake in the 0.7.1 upgrade notes, added in commit d63ca585 for bug 617274. Change-Id: Ibf0a59d86b7d3c3fe9b76f485465e4db2c317cbf